Fix ident format when using HTTP_X_FORWARDED_FOR #2401
Conversation
If NUM_PROXIES setting is set to None, HTTP_X_FORWARDED_FOR might be used as is, which might contain spaces and cause errors on cache backends like memcached.
| ident = request.META.get('REMOTE_ADDR') | ||
| else: | ||
| ident = ''.join(ident.split()) | ||
|
|
There was a problem hiding this comment.
I don't see why those were removed.
There was a problem hiding this comment.
@xordoquy they weren't being used at all.
|
Note: This happens in both v2 and v3. |
|
Looks okay to me - anyone else want to second it? |
| @@ -35,7 +35,7 @@ def get_ident(self, request): | |||
| client_addr = addrs[-min(num_proxies, len(xff))] | |||
There was a problem hiding this comment.
As mentioned in #2400 (comment), this should be len(addrs) instead of len(xff).
|
This should be good to go. Thanks for the reviews. |
Fix ident format when using HTTP_X_FORWARDED_FOR
|
@tomchristie not sure if it's worth fixing this in 2.4 as well. Seems to be workable around easily. Let's see if it comes up again. |
|
The general idea was to drop the 2.4 support since our time is limited. |
I'd have no great argument if somebody wanted to spend their time on that, but I don't think it's a good effort/reward myself, so unless someone wants to get really proactive with making a further 2.4.x release happen then it's a no from me. |
|
👍 |
If
NUM_PROXIESsetting is set to None,HTTP_X_FORWARDED_FORmight be used as is, whichmight contain spaces and cause errors on cache backends like memcached. Ref #2400